Ignore existing warnings; fail on new #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/brakeman.yml generated via: brakeman -z -w2 -q -A --routes --message-limit 200 --table-width 200 \ --github-repo org/repo -4 -i config/brakeman.ignore -d -p . --summary \ --skip-files config/database.yml --safe-methods banana \ --url-safe-methods banana_url --compare reports/brakeman.json -o \ /dev/stdout -o reports/brakeman.json -o reports/brakeman.html -C &> \ config/brakeman.yml config/brakeman.ignore generated via: brakeman -I -c config/brakeman.yml
|
cc @dwradcliffe |
|
So to update the ignore file we just run that command again? |
|
This one ''' Have you reviewed the ignore file for if you're ok w ignoring those things? |
| # :previous_results_json: "./reports/brakeman.json" | ||
| # :output_files: | ||
| # - reports/brakeman.json | ||
| # - reports/brakeman.html |
There was a problem hiding this comment.
Commented out for reference since config docs can be hard to parse at times. And some of these settings are actually added by the script
|
Haven't forgotten about this. I want to get a couple big projects shipped first then we can do this. |
|
☔ The latest upstream changes (presumably #1655) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This PR was too outdated to be worth updating. See #1869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1201
config/brakeman.yml generated via:
brakeman -z -w2 -q -A --routes --message-limit 200 --table-width 200 \ --github-repo rubygems/rubygems.org -4 -i config/brakeman.ignore -d -p . --summary \ --skip-files config/database.yml --safe-methods banana \ --url-safe-methods banana_url --compare reports/brakeman.json -o \ /dev/stdout -o reports/brakeman.json -o reports/brakeman.html -C &> \ config/brakeman.ymlconfig/brakeman.ignore generated via:
brakeman -I -c config/brakeman.yml