Update rubocop from 0.48.1 to 0.49.1 #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style/MultilineOperationIndentation has the wrong namespace - should be Layout Lint/ScriptPermission: Script file release_reserved_namespace doesn't have execute permission. Rails/ApplicationRecord: Models should subclass ApplicationRecord. Style/YodaCondition: Reverse the order of the operands 'development' == r.scope. (https://en.wikipedia.org/wiki/Yoda_conditions)
simi
reviewed
Jun 1, 2017
| @@ -0,0 +1,3 @@ | |||
| class ApplicationRecord < ActiveRecord::Base | |||
There was a problem hiding this comment.
I don't see any reason for this class since it is empty.
There was a problem hiding this comment.
This is a new rails default, so we should keep it even if it's empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Lint/ScriptPermission: Script file release_reserved_namespace doesn't have execute permission.
Rails/ApplicationRecord: Models should subclass ApplicationRecord.
Style/YodaCondition: Reverse the order of the operands 'development' == r.scope. (https://en.wikipedia.org/wiki/Yoda_conditions)