Blacklist derivative spellings of Rails deps #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
reviewed
Aug 9, 2018
Related to rubysec/ruby-advisory-db@b27b958 There's surely a smarter way to blacklist close Levenshtein matches of popular gems but this seems like a good manual first step to ensure no one can easily spoof misspellings of internal Rails gem names.
|
@hsbt Good idea, updated. |
dwradcliffe
approved these changes
Aug 9, 2018
|
@olivierlacan FYI => #1776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rubysec/ruby-advisory-db@b27b958
There's surely a smarter way to blacklist close Levenshtein matches of
popular gems but this seems like a good manual first step to ensure no one
can easily spoof misspellings of internal Rails gem names.