Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pushed by and yanked by to gem show page #1954

Merged
merged 2 commits into from Jun 24, 2019
Merged

Add pushed by and yanked by to gem show page #1954

merged 2 commits into from Jun 24, 2019

Conversation

sonalkr132
Copy link
Member

Screenshot from 2019-04-14 09-51-45

@sonalkr132
Copy link
Member Author

sonalkr132 commented Apr 14, 2019 •
edited

Does pushed by and yanked by need to be this prominent (seperate secion for each)? I tried showing a small dot on owner img but it would fail where pusher is no longer a owner (we could need to fallback to more explicit sections for those). Would the inconsistency and if..else complication be worth it?
Screenshot from 2019-04-13 23-29-20

@sonalkr132 sonalkr132 mentioned this pull request Apr 14, 2019
Closed
@sonalkr132 sonalkr132 merged commit 2cf24f7 into rubygems:master Jun 24, 2019
@sonalkr132 sonalkr132 deleted the pusher branch June 24, 2019 13:57
@rubygems-deployer rubygems-deployer temporarily deployed to staging June 24, 2019 15:21 Inactive
@sonalkr132 sonalkr132 temporarily deployed to production June 24, 2019 15:30 Inactive
@sonalkr132 sonalkr132 mentioned this pull request Jul 15, 2019
Closed
@sonalkr132 sonalkr132 mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sonalkr132 @rubygems-deployer