Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 6 #2018

Merged
merged 12 commits into from Oct 24, 2019

Conversation

@sonalkr132
Copy link
Member

sonalkr132 commented Jun 1, 2019

TODO:

Deprecation

  • render file: should be given the absolute path to a file (called from block (2 levels) in render_not_found at /home/aditya/rubygems.org/app/controllers/application_controller.rb:74, 100)

TODO when we are on rails 6. needs rails 6 new framework config updates.

  • .DEPRECATION WARNING: Sending mail with DeliveryJob and Parameterized::DeliveryJob is deprecated and will be removed in Rails 6.1. Please use MailDeliveryJob instead. (called from call at /home/aditya/rubygems.org/lib/clearance_backdoor.rb:9)

  • DEPRECATION WARNING: Rails 6.1 will return Content-Type header without modification. If you want just the MIME type, please use #media_type instead. (called from block in class:DashboardTest at /home/travis/build/rubygems/rubygems.org/test/integration/dashboard_test.rb:43)

Rails 6 release notes

@sonalkr132 sonalkr132 added this to the Rails 6 update milestone Jun 1, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch from cf0114b to 8aaddd6 Jun 1, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch 3 times, most recently from 1028912 to 4b33efe Jun 18, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch from 4b33efe to 6186ee5 Jun 26, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch 2 times, most recently from 0f6c3c2 to 4e0669a Jul 8, 2019
@sonalkr132 sonalkr132 removed the needs-rebase label Jul 8, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch 2 times, most recently from f3cbe2a to bd49868 Sep 2, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch 2 times, most recently from 96baafc to 5e1164a Oct 7, 2019
@sonalkr132 sonalkr132 marked this pull request as ready for review Oct 7, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch from 5e1164a to 21c144a Oct 7, 2019
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch from 21c144a to 9169dd0 Oct 24, 2019
@sonalkr132 sonalkr132 requested a review from dwradcliffe Oct 24, 2019
sonalkr132 added 10 commits Jun 1, 2019
This commit won't be released. Adding it to test rails rc.

delayed_job 4.1.6 - In Progress
=================
* Allow Rails 6.0
* Update failed message to be more clear
Updates rails from 5.2.1 to 6.0.0.rc1.
rails-i18n couldn't be update seperatly as it depends on railties (>= 6.0.0.beta1, < 7)
Chose not to overwrite config/locales/en.yml, config/initializers/content_security_policy.rb
and config/routes.rb. The files get overridden to prestine rails app config,
with no meaningful changes.
We have commented `require "active_model/railtie"` besides things
not required by default.
Kept small fixes in comments.
sonalkr132 added 2 commits Oct 7, 2019
delayed_job_active_record

Was needed for testing rails 6 rc
@sonalkr132 sonalkr132 force-pushed the sonalkr132:rails-6 branch from 9169dd0 to 13fe2a5 Oct 24, 2019

config.cache_store = :mem_cache_store,
'localhost:11211',

This comment has been minimized.

Copy link
@dwradcliffe

dwradcliffe Oct 24, 2019

Member

Is this default value now?

This comment has been minimized.

Copy link
@simi

simi Oct 24, 2019

Contributor

seems it was default value for whole time, anyway is still in current version -> https://github.com/rails/rails/blob/v6.0.0/activesupport/lib/active_support/cache/mem_cache_store.rb#L70

@simi
simi approved these changes Oct 24, 2019
Copy link
Contributor

simi left a comment

Good job!

@sonalkr132 sonalkr132 merged commit db88e23 into rubygems:master Oct 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sonalkr132 sonalkr132 deleted the sonalkr132:rails-6 branch Oct 24, 2019
sonalkr132 added a commit to sonalkr132/rubygems.org that referenced this pull request Nov 6, 2019
This reverts commit db88e23, reversing
changes made to e01d3df.
sonalkr132 added a commit that referenced this pull request Nov 6, 2019
Revert "Merge pull request #2018 from sonalkr132/rails-6"
@sonalkr132 sonalkr132 deployed to production Nov 6, 2019 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.