Update to Rails 6 #2018
Merged
Update to Rails 6 #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
commented
Jun 1, 2019
sonalkr132
force-pushed
the
rails-6
branch
3 times, most recently
from
1028912
to
4b33efe
Compare
sonalkr132
force-pushed
the
rails-6
branch
2 times, most recently
from
0f6c3c2
to
4e0669a
Compare
sonalkr132
force-pushed
the
rails-6
branch
2 times, most recently
from
f3cbe2a
to
bd49868
Compare
sonalkr132
force-pushed
the
rails-6
branch
2 times, most recently
from
96baafc
to
5e1164a
Compare
This commit won't be released. Adding it to test rails rc. delayed_job 4.1.6 - In Progress ================= * Allow Rails 6.0 * Update failed message to be more clear
Updates rails from 5.2.1 to 6.0.0.rc1. rails-i18n couldn't be update seperatly as it depends on railties (>= 6.0.0.beta1, < 7)
Chose not to overwrite config/locales/en.yml, config/initializers/content_security_policy.rb and config/routes.rb. The files get overridden to prestine rails app config, with no meaningful changes.
We have commented `require "active_model/railtie"` besides things not required by default.
Kept small fixes in comments.
delayed_job_active_record Was needed for testing rails 6 rc
dwradcliffe
approved these changes
Oct 24, 2019
|
|
||
| config.cache_store = :mem_cache_store, | ||
| 'localhost:11211', |
There was a problem hiding this comment.
seems it was default value for whole time, anyway is still in current version -> https://github.com/rails/rails/blob/v6.0.0/activesupport/lib/active_support/cache/mem_cache_store.rb#L70
sonalkr132
added a commit
that referenced
this pull request
Nov 6, 2019
Revert "Merge pull request #2018 from sonalkr132/rails-6"
sonalkr132
added a commit
to sonalkr132/rubygems.org
that referenced
this pull request
Nov 18, 2019
…s-6"" This reverts commit 3327386.
sonalkr132
added a commit
that referenced
this pull request
Nov 18, 2019
Revert "Revert "Merge pull request #2018 from sonalkr132/rails-6""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Deprecation
TODO when we are on rails 6. needs rails 6 new framework config updates.
.DEPRECATION WARNING: Sending mail with DeliveryJob and Parameterized::DeliveryJob is deprecated and will be removed in Rails 6.1. Please use MailDeliveryJob instead. (called from call at /home/aditya/rubygems.org/lib/clearance_backdoor.rb:9)
DEPRECATION WARNING: Rails 6.1 will return Content-Type header without modification. If you want just the MIME type, please use
#media_typeinstead. (called from block in class:DashboardTest at /home/travis/build/rubygems/rubygems.org/test/integration/dashboard_test.rb:43)Rails 6 release notes