Better: Allow to set host in load-pg-dump script #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
reviewed
Oct 6, 2020
| pg_host= | ||
| if [ -n "$host" ]; then | ||
| pg_host="-h $host" | ||
| fi |
There was a problem hiding this comment.
Would using one variable pg_host and using localhost as default for that be simpler than what we are doing here?
There was a problem hiding this comment.
it would be easier indeed but it would break the current behavior of the script. So it is up to you project owners and script users to decide what to do here ;)
There was a problem hiding this comment.
I am not sure I understand how would it break the current behavior. are we talking about PGHOST?
There was a problem hiding this comment.
Because the default is to use the unix socket instead of localhost
sonalkr132
approved these changes
Oct 6, 2020
|
Thank you @ylecuyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CONTRIBUTING.md, one installation method is with docker but the load-pg-dump script defaults to using postgresql locally with the unix socket.
I have added the -H option to set the hostname for postgresql commands. It still works as before is no -H option is given