Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable zeitwerk autoloader #2674

Merged
merged 2 commits into from Mar 21, 2021
Merged

Conversation

sonalkr132
Copy link
Member

this is default for rails 6.0 config. nesting of middlewares was
updated to match expected class names by zeitwerk.

requried to pass `rake zeitwerk:check

NameError: uninitialized constant Hostess

lib is part of autoload_path. we need to explicity exclude folder
from lib which don't need to be autoloated (initializers/zeitwerk.rb).

closes: #2032

this is default for rails 6.0 config. nesting of middlewares was
updated to match expected class names by zeitwerk.

requried to pass `rake zeitwerk:check

```
NameError: uninitialized constant Hostess
```

lib is part of autoload_path. we need to explicity exclude folder
from lib which don't need to be autoloated (initializers/zeitwerk.rb).
Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 maybe it would be worth it to update test classes to match the path (test/unit/hostess_test.rb -> test/unit/gemcutter/middleware/hostess_test.rb and update test class names)

@sonalkr132 sonalkr132 merged commit 1e079cd into rubygems:master Mar 21, 2021
@sonalkr132 sonalkr132 deleted the rails-6-0-default branch March 21, 2021 11:07
@sonalkr132 sonalkr132 temporarily deployed to staging March 21, 2021 15:49 Inactive
@sonalkr132 sonalkr132 temporarily deployed to production March 21, 2021 16:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky parallel pusher test
2 participants