Remove page entries info from gems index page #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are removing info like following from gem index page: > DISPLAYING GEMS 1 - 30 OF 11172 IN TOTAL Showing count means we need to run a select count(*), which becomes expensive (upwards of 400ms) if we are DB is already under load. For past few days, we are receiving traffic for all of index pages being scraped once a day. This is triggering CPU alerts on RDS. Caching won't really help here unless we use an exceptionally large expiry time. IMO, the above info doesn't add any significant value and removing it should be fine.
sonalkr132
force-pushed
the
remove-gems-page-info
branch
from
43aaba6
to
12bf386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing info like following from gem index page:
Showing count means we need to run a select count(*), which becomes
expensive (upwards of 400ms) if DB is already under load. The query is
already using index.
For past few days, we are receiving traffic for all of index pages
being scraped once a day. This is triggering CPU alerts on RDS.
Caching won't really help here unless we use an exceptionally large
expiry time. IMO, the above info doesn't add any significant value
and removing it should be fine.