Update docs and scripts concerning contributing and setup #3300
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
- Coverage 98.57% 98.52% -0.06%
==========================================
Files 113 113
Lines 3372 3390 +18
==========================================
+ Hits 3324 3340 +16
- Misses 48 50 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
martinemde
force-pushed
the
martinemde/contributing-and-setup
branch
2 times, most recently
from
17224a4
to
8f8c7af
Compare
script/setup
Outdated
| echo "DEPRECATED: This script has moved to bin/setup and no longer drops the database." | ||
| echo "Running bin/setup" | ||
| exec "$(dirname "$0")/../bin/setup" |
There was a problem hiding this comment.
I wasn't sure about offering a message like this to help direct to bin/setup vs deleting script/setup entirely. Given the behavior was duplicated for the last 3+ years, I figure leaving a helpful message here is no big deal.
There was a problem hiding this comment.
If the file is useless and is not part of the docs anymore, I think we can just remove it. There is no need for deprecation in here.
martinemde
force-pushed
the
martinemde/contributing-and-setup
branch
from
8f8c7af
to
6b514d5
Compare
Use newer bin/setup instead of script/setup; remove script/setup bin/setup does everything from script/setup besides db:drop which can be manually run when needed.
martinemde
force-pushed
the
martinemde/contributing-and-setup
branch
from
6b514d5
to
9143fca
Compare
|
Review comments addressed. Should be ready to go if there are on objections. |
Since I'm coming into the repository with fresh eyes, I'm passing along the things I felt could be clarified.