Send webhook notifications through an ActiveJob #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the migration from Delayed::Job
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=======================================
Coverage 97.96% 97.97%
=======================================
Files 178 178
Lines 4325 4335 +10
=======================================
+ Hits 4237 4247 +10
Misses 88 88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
simi
reviewed
Feb 28, 2023
| set_tag "gemcutter.notifier.url", url | ||
| set_tag "gemcutter.notifier.webhook_id", webhook.id | ||
|
|
||
| timeout(5) do |
There was a problem hiding this comment.
Super minor idea: What about to wrap timeout into constant since it is used 3 times?
There was a problem hiding this comment.
will probably be replacing this code soon anyways
simi
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the migration from Delayed::Job