New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve styling on the reverse dependencies page #3760
Improve styling on the reverse dependencies page #3760
Conversation
This one is now ready for review. Let me know what you think, thanks! 🙏 |
Yes, that makes sense to me. |
Codecov Report
@@ Coverage Diff @@
## master #3760 +/- ##
==========================================
- Coverage 98.81% 98.81% -0.01%
==========================================
Files 214 213 -1
Lines 5250 5229 -21
==========================================
- Hits 5188 5167 -21
Misses 62 62 |
Thanks @simi for the comments! 🙏 I updated the reverse dependencies page layout so it now matches the gems page. And I've added in this Let me know what you think, thanks! |
68bb7ea
to
88e31a2
Compare
88e31a2
to
7d31826
Compare
7d31826
to
18c1c26
Compare
18c1c26
to
0fdf7cc
Compare
Looks good. Thanks for the PR! |
Resolves #3286
I think we should be OK with reusing the already existing
home__search-wrap
,home__search
, andhome__search__icon
classes we use for the advanced to achieve what we want regarding the styles, let me know what you think 😀Regarding the conditional render, I've tried sticking to the pattern and used
@reverse_dependencies.present?
to render/not render the search bar and results. Got a question here, should we maybe add a note something like "This gem has no reverse dependencies" just to be sure it's clear why we don't render anything? 😀I've included a series of screenshots with the before and after below.
Before the updates
With reverse dependencies present
Without reverse dependencies present
After the updates
With reverse dependencies present
Without reverse dependencies present