Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up kubeconform to lint rendered k8s yaml #3774

Merged
merged 2 commits into from May 21, 2023
Merged

Conversation

segiddins
Copy link
Member

This would have helped catch duplicated keys in the yaml, which broke deploys for a while

@segiddins segiddins requested a review from simi May 7, 2023 20:13
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #3774 (d866149) into master (0caa2ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3774   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         214      214           
  Lines        5244     5244           
=======================================
  Hits         5182     5182           
  Misses         62       62           

This would have helped catch duplicated keys in the yaml, which broke deploys for a while
bundler-cache: true
- name: krane render
run: |
gem exec --silent krane render -f config/deploy/$ENVIRONMENT --bindings=environment=$ENVIRONMENT --current-sha=$REVISION > config/deploy/$ENVIRONMENT.rendered.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@simi simi enabled auto-merge (rebase) May 21, 2023 17:31
auto-merge was automatically disabled May 21, 2023 17:41

Rebase failed

@simi simi merged commit cf037d4 into master May 21, 2023
13 checks passed
@simi simi deleted the segiddins/kubeconform branch May 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants