Add job to upload pre-rendered versions files to S3 #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indirect
approved these changes
May 7, 2023
| @@ -128,6 +128,7 @@ def after_write | |||
| Mailer.gem_pushed(user.id, @version_id, notified_user.id).deliver_later | |||
| end | |||
| Indexer.perform_later | |||
| UploadVersionsFileJob.perform_later | |||
| ReindexRubygemJob.perform_later(rubygem:) | |||
| GemCachePurger.call(rubygem.name) | |||
There was a problem hiding this comment.
Does this need any changes to be delayed until after the background job to update the compact index has completed?
There was a problem hiding this comment.
Not right now -- when we change to serving from S3 by default, we probably want to remove the versions purge from GemCachePurger and only call it in UploadVersionsFileJob, but since we're explicitly only purging the S3 file in UploadVersionsFileJob (and also not serving it by default, see the VCL PR), I think we're good for now
Codecov Report
@@ Coverage Diff @@
## master #3775 +/- ##
=======================================
Coverage 98.80% 98.81%
=======================================
Files 212 213 +1
Lines 5199 5220 +21
=======================================
+ Hits 5137 5158 +21
Misses 62 62
|
segiddins
force-pushed
the
segiddins/s3-versions-file
branch
from
2ea94ad
to
5f22e2c
Compare
segiddins
force-pushed
the
segiddins/s3-versions-file
branch
from
5f22e2c
to
4b3e1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the rails app won't need to serve so many compact index requests per second.
VCL to enable this is in progress.
As a follow-up, we can also upload info files into S3 for the same reason, though that is lower priority.