New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add development environment a default mailer port configuration #3792
Add development environment a default mailer port configuration #3792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3792 +/- ##
==========================================
- Coverage 98.81% 98.81% -0.01%
==========================================
Files 214 213 -1
Lines 5250 5239 -11
==========================================
- Hits 5188 5177 -11
Misses 62 62 |
I've fixed the Rubocop failing scenarios 👍 |
314ce0e
to
3fa574c
Compare
@@ -39,6 +39,7 @@ | |||
# ActionMailer::Base.deliveries array. | |||
config.action_mailer.delivery_method = :test | |||
config.action_mailer.default_url_options = { host: Gemcutter::HOST, | |||
port: "31337", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, does 31337
signify anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, does
31337
signify anything?
No, it's a random port number I configured in the test environment 😅 .
…k helpers tests to consider an optional port in the URL
3fa574c
to
45c2494
Compare
Thanks @juankuquintana! |
At the moment, when opening a mailer link in development mode it does not include the port so it has to be manually added. This PR addresses such problem by adding a default port in the configuration.
rails s -p 3001
as considering such scenario requires code that could be considered "hacky".Testing
Closes #3728