Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the deployed docker image from >350MB to 277MB #3894

Merged
merged 2 commits into from Jul 18, 2023

Conversation

segiddins
Copy link
Member

comments inline. did this because i was getting frustrated at how much data it took to work while tethering remotely and testing out docker file changes

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #3894 (a7505c5) into master (f3140a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3894   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         216      216           
  Lines        5391     5391           
=======================================
  Hits         5326     5326           
  Misses         65       65           

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Dockerfile Outdated Show resolved Hide resolved
@simi
Copy link
Member

simi commented Jul 5, 2023

@segiddins is this ready? I think rebase will fix the codecov.

@segiddins segiddins marked this pull request as ready for review July 7, 2023 00:35
@segiddins
Copy link
Member Author

@simi rebased, it's ready

@segiddins segiddins merged commit 222adb8 into master Jul 18, 2023
13 of 14 checks passed
@segiddins segiddins deleted the segiddins/slim-dockerfile branch July 18, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants