Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avo actions to enqueue compact index file upload jobs #3970

Merged
merged 1 commit into from Jul 30, 2023

Conversation

segiddins
Copy link
Member

So we can manually trigger the jobs if needed (e.g. https://rubygems.org/info/aws-sdk-snowball is missing the latest version, I think we need to wrap the gemcutter stuff in a transaction, will do that separately).

Either way, being able to trigger the jobs seems helpful.

@segiddins segiddins requested a review from indirect July 29, 2023 23:15
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #3970 (6ea3c8f) into master (cdda5b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6ea3c8f differs from pull request most recent head 9d3c3a3. Consider uploading reports for the commit 9d3c3a3 to get more accurate results

@@           Coverage Diff           @@
##           master    #3970   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         221      223    +2     
  Lines        5461     5483   +22     
=======================================
+ Hits         5399     5421   +22     
  Misses         62       62           
Files Changed Coverage Δ
app/avo/actions/upload_info_file.rb 100.00% <100.00%> (ø)
app/avo/actions/upload_versions_file.rb 100.00% <100.00%> (ø)
app/avo/resources/rubygem_resource.rb 100.00% <100.00%> (ø)
app/models/audit.rb 100.00% <100.00%> (ø)

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@segiddins segiddins force-pushed the segiddins/upload-compact-index-file-actions branch from 83ef9b1 to 6ea3c8f Compare July 30, 2023 18:23
@segiddins segiddins enabled auto-merge (squash) July 30, 2023 18:24
Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segiddins would you mind to share when this job is handy to start manually? Was there any recent need for this? 🤔

@segiddins
Copy link
Member Author

See the PR description: there's an /info file missing a version

@simi
Copy link
Member

simi commented Jul 30, 2023

See the PR description: there's an /info file missing a version

Ahh, sorry. I have misunderstood the original description. All clear now.

@segiddins segiddins force-pushed the segiddins/upload-compact-index-file-actions branch from 6ea3c8f to 9d3c3a3 Compare July 30, 2023 18:56
@segiddins segiddins merged commit 9e93a64 into master Jul 30, 2023
11 checks passed
@segiddins segiddins deleted the segiddins/upload-compact-index-file-actions branch July 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants