Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer sponsor images being cut off at some screen widths #3996

Merged
merged 1 commit into from Aug 18, 2023

Conversation

martinemde
Copy link
Member

@martinemde martinemde commented Aug 18, 2023

Changes scaling of sponsor images so they always stay the same size for all screen widths.

Fixes #3994

Screen.Recording.2023-08-17.at.8.41.45.PM.mov

@martinemde martinemde changed the title Fix footer sponsor images being cut off at some screne widths Fix footer sponsor images being cut off at some screen widths Aug 18, 2023
Changes scaling of sponsor images so they always stay the same size for
all screen widths.
@martinemde martinemde force-pushed the martinemde/fix-sponsor-logo-cutoff branch from 2c5d45c to 5a4f3e3 Compare August 18, 2023 03:54
@@ -172,41 +172,39 @@
</div>
</div>
</div>
<div class="footer__sponsors-wrap">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed this div and re-indented. No other changes.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3996 (5a4f3e3) into master (a2ae029) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3996   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         260      260           
  Lines        6026     6026           
=======================================
  Hits         5961     5961           
  Misses         65       65           

@martinemde martinemde merged commit c65cb14 into master Aug 18, 2023
13 checks passed
@martinemde martinemde deleted the martinemde/fix-sponsor-logo-cutoff branch August 18, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby Central logo is cut off on narrow window sizes
2 participants