Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching for a user in avo api key role resource #4000

Merged
merged 2 commits into from Aug 19, 2023

Conversation

segiddins
Copy link
Member

Otherwise, the page hangs while trying to load every single user

@segiddins segiddins enabled auto-merge (squash) August 19, 2023 16:38
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #4000 (f52fc2d) into master (c65cb14) will decrease coverage by 0.14%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head f52fc2d differs from pull request most recent head bed1866. Consider uploading reports for the commit bed1866 to get more accurate results

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage   98.92%   98.78%   -0.14%     
==========================================
  Files         260      260              
  Lines        6026     6027       +1     
==========================================
- Hits         5961     5954       -7     
- Misses         65       73       +8     
Files Changed Coverage Δ
app/avo/resources/oidc_api_key_role_resource.rb 100.00% <100.00%> (ø)
app/avo/resources/user_resource.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Otherwise, the page hangs while trying to load every single user
@segiddins segiddins force-pushed the segiddins/api_key_role_search branch from f52fc2d to 488c7c2 Compare August 19, 2023 17:23
@segiddins segiddins merged commit baa3d42 into master Aug 19, 2023
11 checks passed
@segiddins segiddins deleted the segiddins/api_key_role_search branch August 19, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant