Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile assets on CI before running tests. #4059

Merged
merged 1 commit into from Sep 27, 2023
Merged

Conversation

simi
Copy link
Member

@simi simi commented Sep 9, 2023

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #4059 (d4196f0) into master (9f19e00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4059   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         268      268           
  Lines        6168     6168           
=======================================
  Hits         6107     6107           
  Misses         61       61           

@simi simi requested a review from segiddins September 9, 2023 17:27
@simi simi marked this pull request as ready for review September 9, 2023 17:27
@segiddins
Copy link
Member

Are we concerned about this leading to CI having a different behavior than most people running tests locally?

@simi
Copy link
Member Author

simi commented Sep 9, 2023

Are we concerned about this leading to CI having a different behavior than most people running tests locally?

TBH I'm not sure. Feel free to close this if you're not 100% sure about the impact. Splitting the CI at #4059 would make it easier to detect the original problem later if merged anyway.

@martinemde
Copy link
Member

I've done this same thing to avoid timeouts during capybara tests. Is that what this aims to fix?

@simi
Copy link
Member Author

simi commented Sep 9, 2023

I've done this same thing to avoid timeouts during capybara tests. Is that what this aims to fix?

Yes

@simi simi merged commit 0c09a83 into master Sep 27, 2023
16 checks passed
@simi simi deleted the precompile-assets-ci branch September 27, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants