Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC adding tailwind #4113

Merged
merged 3 commits into from Oct 19, 2023
Merged

POC adding tailwind #4113

merged 3 commits into from Oct 19, 2023

Conversation

segiddins
Copy link
Member

Had to disable the base/preflight stuff because the CSS resets were breaking existing designs. This gives us a blank slate.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4113 (cd310b6) into master (885f10e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4113   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         279      279           
  Lines        6317     6317           
=======================================
  Hits         6247     6247           
  Misses         70       70           

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, and like a good starting point towards eventually migrating onto newer tools.

@simi
Copy link
Member

simi commented Oct 7, 2023

What's the plan in here? 🤔

@indirect
Copy link
Member

indirect commented Oct 7, 2023

My hope is something like:

  1. make tailwind available for use (this PR)
  2. new UI features can use tailwind for layout and design
  3. in the next 1-3 months, engage a designer to work on the planned new gem show page and updated visual design
  4. use Tailwind to implement new gem pages and updated visual design
  5. remove sass, bourbon, compass, and other older frontend packages

@simi
Copy link
Member

simi commented Oct 7, 2023

@indirect sounds great.

What about to merge this with also new pipeline onboarding like #3470? Would it be possible to move only tailwind part to new pipeline and slowly offboard the old one?

@indirect
Copy link
Member

indirect commented Oct 8, 2023

I am happy for the modern pipeline to be either stripped-down sprockets or propshaft—I'm not sure if propshaft has enough bugs worked out yet to work for us, but if it does work for us I am happy to use it. Either way, I don't want to block any PR on another PR, we can merge this and then shift app/build from Sprockets to Propshaft when the Propshaft PR lands. 👍🏻

@segiddins segiddins marked this pull request as ready for review October 10, 2023 16:52
@indirect
Copy link
Member

@segiddins let's resolve the merge conflict and get this one landed before any more conflicts crop up. the future stuff outlined here can happen in the future. 👍🏻

@segiddins
Copy link
Member Author

Rebased

@simi
Copy link
Member

simi commented Oct 19, 2023

🤔 I still do not understand why tailwind is needed. But I'm not going to block this.

@indirect indirect merged commit a75f418 into master Oct 19, 2023
16 checks passed
@indirect indirect deleted the segiddins/tailwind branch October 19, 2023 23:34
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging October 19, 2023 23:44 Inactive
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production October 20, 2023 17:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants