New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC adding tailwind #4113
POC adding tailwind #4113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4113 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 279 279
Lines 6317 6317
=======================================
Hits 6247 6247
Misses 70 70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, and like a good starting point towards eventually migrating onto newer tools.
What's the plan in here? 🤔 |
My hope is something like:
|
I am happy for the modern pipeline to be either stripped-down sprockets or propshaft—I'm not sure if propshaft has enough bugs worked out yet to work for us, but if it does work for us I am happy to use it. Either way, I don't want to block any PR on another PR, we can merge this and then shift |
0ff3bcf
to
9c71de7
Compare
@segiddins let's resolve the merge conflict and get this one landed before any more conflicts crop up. the future stuff outlined here can happen in the future. 👍🏻 |
fbb60ee
to
cd310b6
Compare
Rebased |
🤔 I still do not understand why tailwind is needed. But I'm not going to block this. |
Had to disable the base/preflight stuff because the CSS resets were breaking existing designs. This gives us a blank slate.