Clarify Ownership uniqueness errors when user already invited or owner #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 276 276
Lines 6273 6281 +8
=======================================
+ Hits 6204 6212 +8
Misses 69 69
|
martinemde
force-pushed
the
owneship-validations
branch
from
bcc8ffc
to
5e3ec5a
Compare
martinemde
changed the title
segiddins
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deivid-rodriguez had an experience adding a user to owners that wasn't ideal. I threw this together to try to make the error make more sense, since unconfirmed owners won't show up on the list of owners.