-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Repr-Digest header in compact index #4174
Conversation
502a407
to
f34903c
Compare
Let's sync somewhere which HTTP Digest headers to support. Also is there any reason to not keep just |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4174 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 301 301
Lines 6822 6822
=======================================
Hits 6735 6735
Misses 87 87 ☔ View full report in Codecov by Sentry. |
Note: This should change to |
f34903c
to
4a1d33e
Compare
4a1d33e
to
426cf3b
Compare
@simi, when talking with @segiddins we thought we would leave Digest header for now. Do you think we should also remove the colons from Digest to keep it identical? Can we safely assume no one is using Digest today that would be impacted? |
Repr-Digest is the digest of the entire representation, the full file. Continue to support Digest for the time being, even though there are no official or known clients that use it.
426cf3b
to
6d65937
Compare
I decided to go ahead and convert this to be exactly backwards compatible (thank you recorded Matz). |
Supports rubygems/rubygems#7122 with non-deprecated (draft)1 header for the digest of the full file representation even if only a part of the file is returned. Converts the header to use colon boundaries for byte sequences2 in headers.
Footnotes
RFC draft (link to Repr-Digest example that distinguishes behavior) ↩
RFC 8941 Structured Fields https://www.rfc-editor.org/rfc/rfc8941.html#name-byte-sequences ↩