Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Repr-Digest header in compact index #4174

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

martinemde
Copy link
Member

@martinemde martinemde commented Nov 2, 2023

Supports rubygems/rubygems#7122 with non-deprecated (draft)1 header for the digest of the full file representation even if only a part of the file is returned. Converts the header to use colon boundaries for byte sequences2 in headers.

Footnotes

  1. RFC draft (link to Repr-Digest example that distinguishes behavior)

  2. RFC 8941 Structured Fields https://www.rfc-editor.org/rfc/rfc8941.html#name-byte-sequences

@martinemde martinemde marked this pull request as ready for review November 2, 2023 20:38
@martinemde martinemde force-pushed the martinemde/quoted-content-digest-header branch from 502a407 to f34903c Compare November 2, 2023 20:39
@martinemde martinemde requested review from simi and segiddins and removed request for simi November 2, 2023 20:39
@simi
Copy link
Member

simi commented Nov 2, 2023

Let's sync somewhere which HTTP Digest headers to support. Also is there any reason to not keep just Digest one for potential backward compatibility?

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0096211) 98.72% compared to head (4a1d33e) 98.72%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4174   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         301      301           
  Lines        6822     6822           
=======================================
  Hits         6735     6735           
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinemde martinemde marked this pull request as draft November 3, 2023 00:50
@martinemde
Copy link
Member Author

Note: This should change to Repr-Digest.

@martinemde martinemde force-pushed the martinemde/quoted-content-digest-header branch from f34903c to 4a1d33e Compare November 13, 2023 22:18
@martinemde martinemde changed the title Use Content-Digest header in compact index Return Repr-Digest header in compact index Nov 13, 2023
@martinemde martinemde marked this pull request as ready for review November 13, 2023 22:24
@martinemde martinemde force-pushed the martinemde/quoted-content-digest-header branch from 4a1d33e to 426cf3b Compare November 13, 2023 22:41
@martinemde
Copy link
Member Author

@simi, when talking with @segiddins we thought we would leave Digest header for now.

Do you think we should also remove the colons from Digest to keep it identical? Can we safely assume no one is using Digest today that would be impacted?

@martinemde martinemde requested review from simi and removed request for simi November 14, 2023 06:47
Repr-Digest is the digest of the entire representation, the full file.
Continue to support Digest for the time being, even though there are no
official or known clients that use it.
@martinemde martinemde force-pushed the martinemde/quoted-content-digest-header branch from 426cf3b to 6d65937 Compare November 14, 2023 17:52
@martinemde
Copy link
Member Author

I decided to go ahead and convert this to be exactly backwards compatible (thank you recorded Matz).

@martinemde martinemde enabled auto-merge (squash) November 14, 2023 17:58
@martinemde martinemde merged commit 3820e93 into master Nov 14, 2023
14 checks passed
@martinemde martinemde deleted the martinemde/quoted-content-digest-header branch November 14, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants