Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to refresh all OIDC provider configs every 30m #4211

Merged
merged 1 commit into from Nov 20, 2023

Conversation

segiddins
Copy link
Member

So they do not need to be manually refreshed. In effect, this makes the config and jwks columns in the table a cache with a 30min TTL with stale-while-revalidate.

So they do not need to be manually refreshed
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d630c5e) 98.72% compared to head (318f4fd) 98.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4211   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         301      302    +1     
  Lines        6824     6829    +5     
=======================================
+ Hits         6737     6742    +5     
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That s in the job class name took me a moment to see. I was wondering what sort of recursive Rube Goldberg machine we were making here. Seems fine now that I get it ;)

@segiddins segiddins merged commit 159632f into master Nov 20, 2023
16 checks passed
@segiddins segiddins deleted the segiddins/oidc-auto-refresh branch November 20, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants