Update to ruby 3.3 completely #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/update-to-ruby-3.3
branch
from
69f5727
to
eee521d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4320 +/- ##
==========================================
- Coverage 98.73% 98.73% -0.01%
==========================================
Files 336 336
Lines 7415 7414 -1
==========================================
- Hits 7321 7320 -1
Misses 94 94 ☔ View full report in Codecov by Sentry. |
simi
reviewed
Dec 30, 2023
simi
approved these changes
Dec 30, 2023
| @@ -25,11 +25,7 @@ ENV BUNDLE_APP_CONFIG=".bundle_app_config" | |||
|
|
|||
| # Update rubygems | |||
| ARG RUBYGEMS_VERSION | |||
| RUN gem update --system ${RUBYGEMS_VERSION} --no-document && \ | |||
| # rubygems-update is completely unused after the `gem update --system` process | |||
| gem uninstall rubygems-update -x && \ | |||
There was a problem hiding this comment.
Interesting! I think the comment above is still true, and I would expect gem uninstall rubygems-update -x to still work. I was actually considering recently that this should be the default behavior and no rubygems-update gem should be left around. Maybe some rubygems regression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.