Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offboard clipboard texts to reusable localized strings. #4354

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

simi
Copy link
Member

@simi simi commented Jan 15, 2024

DRY copy strings

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eb84d0) 98.73% compared to head (456a76e) 98.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4354   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         336      336           
  Lines        7431     7431           
=======================================
  Hits         7337     7337           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi simi merged commit d922ce6 into master Jan 15, 2024
16 checks passed
@simi simi deleted the copied branch January 15, 2024 05:57
robbyrussell added a commit to robbyrussell/rubygems.org that referenced this pull request Jan 19, 2024
simi pushed a commit to robbyrussell/rubygems.org that referenced this pull request Jun 13, 2024
simi added a commit that referenced this pull request Jun 14, 2024
)

* Providing users with a copy-to-clipboard feature for the checksum.

* Updating i18n keys for the reusable copy_to_clipboard/copied locales given changes in #4354. #4353

* Update versions test.

---------

Co-authored-by: Josef Šimánek <josef.simanek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants