Add previously missing german translations #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @CuddlyBunion341 and thanks for the translations. I'll leave this open for few days to make it possible to another 🇩🇪 speaking person to do review. Per my basic 🇩🇪 language knowledge it looks ok. No worries, tests are not needed for translations (should we update the template?). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 391 391
Lines 8260 8260
=======================================
Hits 8025 8025
Misses 235 235 ☔ View full report in Codecov by Sentry. |
|
@CuddlyBunion341 might you involve somebody else at Renuo for a review? We have tons of german speakers ;) |
|
I'll try my best to @coorasse. |
ekyburz
reviewed
Feb 22, 2024
simi
force-pushed
the
cuddlybunion341/add-german-translations
branch
from
a0931e8
to
398b148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many translations needed to be included previously on rubygems.org, especially on the landing page. This Pull Request is my attempt at translating the locales based on English and French translations, despite https://github.com/rubygems/rubygems.org/blob/master/CONTRIBUTING.md#acceptance mentioning that the community won't accept contributions without tests. In my understanding, this rule shouldn't affect configuration/locale files.
Thank you for considering this contribution!