Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable loading YAML with aliases #4603

Merged
merged 1 commit into from Apr 15, 2024

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Apr 11, 2024

Prevent loading YAML files with aliases, which can be used to construct YAML bombs that lead to OOMs

Makes use of rubygems/rubygems#7464

Fixes https://github.com/rubygems/rubygems.org/security/advisories/GHSA-4vc5-whwr-7hh2

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (3797f33) to head (539de00).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4603   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files         390      391    +1     
  Lines        8187     8230   +43     
=======================================
+ Hits         7948     7990   +42     
- Misses        239      240    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins force-pushed the segiddins/disable-loading-yaml-with-aliases branch from 654f0d5 to 732a671 Compare April 12, 2024 16:19
Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we include the exact remediation steps in the error message? eg “run gem update —system and try again” or whatever the correct command would be.

@segiddins segiddins force-pushed the segiddins/disable-loading-yaml-with-aliases branch 3 times, most recently from 3a6f490 to 539de00 Compare April 15, 2024 22:55
@segiddins segiddins enabled auto-merge (squash) April 15, 2024 22:56
Prevent loading YAML files with aliases, which can be used to construct YAML bombs that lead to OOMs

Makes use of rubygems/rubygems#7464
@segiddins segiddins force-pushed the segiddins/disable-loading-yaml-with-aliases branch from 539de00 to 6469883 Compare April 15, 2024 23:43
@segiddins segiddins merged commit 8fc65db into master Apr 15, 2024
15 checks passed
@segiddins segiddins deleted the segiddins/disable-loading-yaml-with-aliases branch April 15, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants