Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy API key scope columns #4688

Merged
merged 2 commits into from
May 31, 2024

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented May 7, 2024

They are already ignored & unused

To be deployed after #4687

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (d4e8926) to head (98c2cdc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4688   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         393      393           
  Lines        8319     8319           
=======================================
  Hits         8080     8080           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins force-pushed the segiddins/drop-legacy-api-key-scope-columns branch from 06f8324 to 1e2e402 Compare May 7, 2024 18:42
@segiddins segiddins force-pushed the segiddins/ignore-legacy-api-key-scope-columns-in-preparation-for-removal branch 2 times, most recently from cb8fe4f to bba5a44 Compare May 8, 2024 06:54
Base automatically changed from segiddins/ignore-legacy-api-key-scope-columns-in-preparation-for-removal to master May 8, 2024 15:16
@segiddins segiddins force-pushed the segiddins/drop-legacy-api-key-scope-columns branch 2 times, most recently from a08665f to 8598f89 Compare May 13, 2024 15:05
@segiddins segiddins marked this pull request as ready for review May 13, 2024 15:05
They are already ignored & unused
@simi simi force-pushed the segiddins/drop-legacy-api-key-scope-columns branch from 8598f89 to 9de81aa Compare May 18, 2024 09:08
@segiddins segiddins requested a review from simi May 21, 2024 20:25
@simi
Copy link
Member

simi commented May 31, 2024

ℹ️ #4687 deployed, merging

@simi simi enabled auto-merge (squash) May 31, 2024 17:13
@simi simi disabled auto-merge May 31, 2024 17:13
@simi simi enabled auto-merge (rebase) May 31, 2024 17:14
auto-merge was automatically disabled May 31, 2024 17:30

Rebase failed

@simi simi merged commit 02fbbfb into master May 31, 2024
17 checks passed
@simi simi deleted the segiddins/drop-legacy-api-key-scope-columns branch May 31, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants