Add trusted publisher API #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4690 +/- ##
==========================================
- Coverage 97.09% 96.98% -0.12%
==========================================
Files 392 393 +1
Lines 8275 8322 +47
==========================================
+ Hits 8035 8071 +36
- Misses 240 251 +11 ☔ View full report in Codecov by Sentry. |
simi
reviewed
May 7, 2024
simi
reviewed
May 7, 2024
indirect
approved these changes
May 7, 2024
segiddins
force-pushed
the
segiddins/trusted-publishers-api
branch
from
ec15a32 to
99379c1
Compare
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
segiddins
force-pushed
the
segiddins/trusted-publishers-api
branch
from
99379c1 to
4554d83
Compare
martinemde
approved these changes
May 8, 2024
martinemde
pushed a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow creating, viewing, and deleting trusted publishers for a gem, gated behind a new API scope!
Open to feedback on specific test cases I should add.
I specifically am not adding an API for pending publishers yet, that can be done in a follow-up.
This will allow me to write a hack day tool to automatically set up trusted publishing for an existing gem!