Skip to content

Commit

Permalink
Merge pull request #7648 from rubygems/deivid-rodriguez/recommend-bin…
Browse files Browse the repository at this point in the history
…-rake

Recommend `bin/rake` over `rake`
  • Loading branch information
simi committed May 10, 2024
2 parents 936827c + e78a986 commit 17f73c2
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"remoteUser": "vscode",
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
// Use 'postCreateCommand' to run commands after the container is created.
"onCreateCommand": "rake setup",
"onCreateCommand": "bin/rake setup",
// Use 'updateContentCommand' to run commands when the container is updated.
"updateContentCommand": "rake update",
"updateContentCommand": "bin/rake update",
// Configure tool-specific properties.
"containerEnv": {
"EDITOR": "code --wait",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily-rubygems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:

- name: Test rubygems
run: |
rake setup
rake test
bin/rake setup
bin/rake test
- name: Get previous status
if: always()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/realworld-bundler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
ruby-version: 3.3.1
bundler: none
- name: Prepare dependencies
run: rake setup
run: bin/rake setup
- name: Download all used cassettes as artifacts
uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/rubygems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ jobs:
echo "BINDGEN_EXTRA_CLANG_ARGS=$((gcm clang).source -replace "bin\clang.exe","include")" >> $env:GITHUB_ENV
if: matrix.ruby.name == 'mswin'
- name: Install Dependencies
run: rake setup
run: bin/rake setup
- name: Run Test
run: rake test
run: bin/rake test
if: matrix.ruby.name != 'truffleruby' && matrix.ruby.name != 'jruby'
- name: Run Test isolatedly
run: rake test:isolated
run: bin/rake test:isolated
if: matrix.ruby.name == '3.3' && matrix.os.name != 'Windows'
- name: Run Test (JRuby)
run: JRUBY_OPTS=--debug rake test
run: JRUBY_OPTS=--debug bin/rake test
if: startsWith(matrix.ruby.name, 'jruby')
- name: Run Test (Truffleruby)
run: TRUFFLERUBYOPT="--experimental-options --testing-rubygems" rake test
run: TRUFFLERUBYOPT="--experimental-options --testing-rubygems" bin/rake test
if: matrix.ruby.name == 'truffleruby'

timeout-minutes: 60
6 changes: 3 additions & 3 deletions .github/workflows/ubuntu-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
ruby-version: 3.3.1
bundler: none
- name: Install Dependencies
run: rake setup
run: bin/rake setup
- name: Run Lint
run: rake rubocop
run: bin/rake rubocop
- name: Generate docs
run: rake docs
run: bin/rake docs
- name: Install & Check Dependencies
run: bin/rake dev:frozen_deps
- name: Misc checks
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ here: https://guides.rubygems.org/contributing/

### Installing dependencies

rake setup
bin/rake setup

> **NOTE**: If the above fails with permission related errors, you're most
> likely using a global Ruby installation (like the one packaged by your OS),
Expand All @@ -58,7 +58,7 @@ To run commands like `bundle install` from the repo:

To run the entire test suite you can use:

rake test
bin/rake test

To run an individual test file located for example in `test/rubygems/test_deprecate.rb` you can use:

Expand Down

0 comments on commit 17f73c2

Please sign in to comment.