Skip to content

Commit

Permalink
Disable gemdeps detection when building extensions
Browse files Browse the repository at this point in the history
If an extension has an Gemfile or Isolate file RubyGems would try to
load this when building the extension.  This could cause failures if the
unsupported bundler API methods were used.

RubyGems now disables gemdeps file detection when building extensions.

Fixes #436
  • Loading branch information
drbrain committed Feb 5, 2013
1 parent 13664ae commit 1ca11d0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/rubygems/ext/builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def self.run(command, results, command_name = nil)
verbose = Gem.configuration.really_verbose

begin
#rubygems_gemdeps, ENV['RUBYGEMS_GEMDEPS'] = ENV['RUBYGEMS_GEMDEPS'], nil
rubygems_gemdeps, ENV['RUBYGEMS_GEMDEPS'] = ENV['RUBYGEMS_GEMDEPS'], nil
if verbose
puts(command)
system(command)
Expand All @@ -53,7 +53,7 @@ def self.run(command, results, command_name = nil)
results << `#{command} #{redirector}`
end
ensure
#ENV['RUBYGEMS_GEMDEPS'] = rubygems_gemdeps
ENV['RUBYGEMS_GEMDEPS'] = rubygems_gemdeps
end

unless $?.success? then
Expand Down

0 comments on commit 1ca11d0

Please sign in to comment.