remove explicit require(s) for auto-loaded constant(s)

the Gem module's auto-loads will handle loading these as needed, this started as a redundancy found in *rubygems.rb* which had: `autoload :Specification, 'rubygems/specification'` as well as `require 'rubygems/specification'`
rubygems · Jun 27, 2020 · 43ceae7 · 43ceae7
1 parent 3c7f249
commit 43ceae7
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 13 deletions.
diff --git a/lib/rubygems.rb b/lib/rubygems.rb
@@ -1335,8 +1335,6 @@ def default_gem_load_paths
   autoload :Specification,      File.expand_path('rubygems/specification', __dir__)
   autoload :Util,               File.expand_path('rubygems/util', __dir__)
   autoload :Version,            File.expand_path('rubygems/version', __dir__)
-
-  require "rubygems/specification"
 end
 
 require 'rubygems/exceptions'

diff --git a/lib/rubygems/dependency.rb b/lib/rubygems/dependency.rb
@@ -2,9 +2,6 @@
 ##
 # The Dependency class holds a Gem name and a Gem::Requirement.
 
-require "rubygems/bundler_version_finder"
-require "rubygems/requirement"
-
 class Gem::Dependency
 
   ##

diff --git a/lib/rubygems/gem_runner.rb b/lib/rubygems/gem_runner.rb
@@ -7,7 +7,6 @@
 
 require 'rubygems'
 require 'rubygems/command_manager'
-require 'rubygems/config_file'
 require 'rubygems/deprecate'
 
 ##

diff --git a/lib/rubygems/name_tuple.rb b/lib/rubygems/name_tuple.rb
@@ -4,8 +4,6 @@
 # Represents a gem of name +name+ at +version+ of +platform+. These
 # wrap the data returned from the indexes.
 
-require 'rubygems/platform'
-
 class Gem::NameTuple
 
   def initialize(name, version, platform="ruby")

diff --git a/lib/rubygems/package.rb b/lib/rubygems/package.rb
@@ -43,7 +43,6 @@
 
 require "rubygems"
 require 'rubygems/security'
-require 'rubygems/specification'
 require 'rubygems/user_interaction'
 require 'zlib'
 

diff --git a/lib/rubygems/requirement.rb b/lib/rubygems/requirement.rb
@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require "rubygems/version"
 require "rubygems/deprecate"
 
 ##

diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb
@@ -6,9 +6,6 @@
 # See LICENSE.txt for permissions.
 #++
 
-require 'rubygems/version'
-require 'rubygems/requirement'
-require 'rubygems/platform'
 require 'rubygems/deprecate'
 require 'rubygems/basic_specification'
 require 'rubygems/stub_specification'