Only run optional validations in packaging contexts

rubygems · May 31, 2020 · 4d848a6 · 4d848a6
1 parent 63076c4
commit 4d848a6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb
@@ -44,7 +44,7 @@ def initialize(specification)
   def validate(strict = false)
     validate_required!
 
-    validate_optional(strict)
+    validate_optional(strict) if packaging || strict
 
     true
   end

diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb
@@ -3141,6 +3141,17 @@ def test_validate_license
     WARNING
   end
 
+  def test_validate_license_in_a_non_packaging_context
+    util_setup_validate
+
+    use_ui @ui do
+      @a1.licenses.clear
+      @a1.validate(false)
+    end
+
+    assert_empty @ui.error
+  end
+
   def test_removed_methods
     assert_equal Gem::Specification::REMOVED_METHODS, [:rubyforge_project=]
   end