Fix matching of linux platforms with eabi modifiers

Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
rubygems · Sep 29, 2022 · 89362c1 · 89362c1
1 parent 4075771
commit 89362c1
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 8 deletions.
diff --git a/bundler/lib/bundler/rubygems_ext.rb b/bundler/lib/bundler/rubygems_ext.rb
@@ -261,7 +261,7 @@ def ===(other)
           # version
           (
             (@os != "linux" && (@version.nil? || other.version.nil?)) ||
-            (@os == "linux" && (normalized_linux_version_ext == other.normalized_linux_version_ext || other.version == "musl#{@version}")) ||
+            (@os == "linux" && (normalized_linux_version_ext == other.normalized_linux_version_ext || other.version == "musl#{@version}" || other.version == "musleabi#{@version}")) ||
             @version == other.version
           )
       end
@@ -271,10 +271,10 @@ def ===(other)
       def normalized_linux_version_ext
         return nil unless @version
 
-        without_gnu = @version.sub(/\Agnu/, "")
-        return nil if without_gnu.empty?
+        without_gnu_nor_abi_modifiers = @version.sub(/\Agnu/, "").sub(/eabi\Z/, "")
+        return nil if without_gnu_nor_abi_modifiers.empty?
 
-        without_gnu
+        without_gnu_nor_abi_modifiers
       end
     end
   end

diff --git a/lib/rubygems/platform.rb b/lib/rubygems/platform.rb
@@ -181,18 +181,18 @@ def ===(other)
       # version
       (
         (@os != "linux" && (@version.nil? || other.version.nil?)) ||
-        (@os == "linux" && (normalized_linux_version == other.normalized_linux_version || other.version == "musl#{@version}")) ||
+        (@os == "linux" && (normalized_linux_version == other.normalized_linux_version || other.version == "musl#{@version}" || other.version == "musleabi#{@version}")) ||
         @version == other.version
       )
   end
 
   def normalized_linux_version
     return nil unless @version
 
-    without_gnu = @version.sub(/\Agnu/, "")
-    return nil if without_gnu.empty?
+    without_gnu_nor_abi_modifiers = @version.sub(/\Agnu/, "").sub(/eabi\Z/, "")
+    return nil if without_gnu_nor_abi_modifiers.empty?
 
-    without_gnu
+    without_gnu_nor_abi_modifiers
   end
 
   ##

diff --git a/test/rubygems/test_gem_platform.rb b/test/rubygems/test_gem_platform.rb
@@ -333,6 +333,26 @@ def test_eabi_version_is_stricter_for_linux_os
     refute(arm_linux_uclibceabi === arm_linux_eabi, "linux-uclibceabi =~ linux-eabi")
   end
 
+  def test_eabi_and_nil_version_combination_strictness
+    arm_linux = Gem::Platform.new "arm-linux"
+    arm_linux_eabi = Gem::Platform.new "arm-linux-eabi"
+    arm_linux_gnueabi = Gem::Platform.new "arm-linux-gnueabi"
+    arm_linux_musleabi = Gem::Platform.new "arm-linux-musleabi"
+    arm_linux_uclibceabi = Gem::Platform.new "arm-linux-uclibceabi"
+
+    # generic arm host runtime with eabi modifier accepts generic arm gems
+    assert(arm_linux === arm_linux_eabi, "arm-linux =~ arm-linux-eabi")
+
+    # explicit gnu arm host runtime with eabi modifier accepts generic arm gems
+    assert(arm_linux === arm_linux_gnueabi, "arm-linux =~ arm-linux-gnueabi")
+
+    # musl arm host runtime accepts libc-generic or statically linked gems...
+    assert(arm_linux === arm_linux_musleabi, "arm-linux =~ arm-linux-musleabi")
+
+    # other libc arm hosts are not glibc compatible
+    refute(arm_linux === arm_linux_uclibceabi, "arm-linux =~ arm-linux-uclibceabi")
+  end
+
   def test_equals3_cpu_arm
     arm   = Gem::Platform.new "arm-linux"
     armv5 = Gem::Platform.new "armv5-linux"