Skip to content

Commit

Permalink
Build the first gemspec we found if no gemspec is specified
Browse files Browse the repository at this point in the history
  • Loading branch information
bronzdoc committed Aug 23, 2019
1 parent dc70c5a commit ab18626
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 1 deletion.
10 changes: 9 additions & 1 deletion lib/rubygems/commands/build_command.rb
Expand Up @@ -57,11 +57,19 @@ def usage # :nodoc:
end

def execute
build_gem
build_gem(gem_name)
end

private

def gem_name
get_one_optional_argument || find_gemspecs.first
end

def find_gemspecs
Dir.glob("*.gemspec").sort
end

def build_gem(gem_name = get_one_optional_argument)
gemspec = File.exist?(gem_name) ? gem_name : "#{gem_name}.gemspec"

Expand Down
39 changes: 39 additions & 0 deletions test/rubygems/test_gem_commands_build_command.rb
Expand Up @@ -242,6 +242,45 @@ def test_can_find_gemspecs_without_dot_gemspec
util_test_build_gem @gem
end

def test_execute_without_gem_name
some_gem = util_spec "some_gem" do |s|
s.license = "AGPL-3.0"
s.files = ["README.md"]
end

gemspec_dir = File.join(@tempdir, "build_command_gem")
gemspec_file = File.join(gemspec_dir, some_gem.spec_name)
readme_file = File.join(gemspec_dir, 'README.md')

FileUtils.mkdir_p(gemspec_dir)

File.open(readme_file, "w") do |f|
f.write("My awesome gem")
end

File.open(gemspec_file, "w") do |gs|
gs.write(some_gem.to_ruby)
end

@cmd.options[:args] = []

use_ui @ui do
Dir.chdir(gemspec_dir) do
@cmd.execute
end
end

output = @ui.output.split("\n")
assert_equal " Successfully built RubyGem", output.shift
assert_equal " Name: some_gem", output.shift
assert_equal " Version: 2", output.shift
assert_equal " File: some_gem-2.gem", output.shift
assert_equal [], output

some_gem = File.join(gemspec_dir, File.basename(some_gem.cache_file))
assert File.exist?(some_gem)
end

def util_test_build_gem(gem)
use_ui @ui do
Dir.chdir @tempdir do
Expand Down

0 comments on commit ab18626

Please sign in to comment.