Expand github paths when no slash is found

This matches bundler behavior for github gem dependencies.
rubygems · Jul 31, 2014 · d710c08 · d710c08
1 parent 708d40b
commit d710c08
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/rubygems/request_set/gem_dependency_api.rb b/lib/rubygems/request_set/gem_dependency_api.rb
@@ -415,6 +415,8 @@ def gem_git name, options # :nodoc:
   def gem_github name, options # :nodoc:
     return unless path = options.delete(:github)
 
+    path = "#{path}/#{path}" unless path.include? "/"
+
     options[:git] = "git://github.com/#{path}.git"
 
     gem_git name, options

diff --git a/test/rubygems/test_gem_request_set_gem_dependency_api.rb b/test/rubygems/test_gem_request_set_gem_dependency_api.rb
@@ -151,6 +151,19 @@ def test_gem_github
     assert_equal expected, @gda.dependencies
   end
 
+  def test_gem_github_expand_path
+    @gda.gem 'a', :github => 'example'
+
+    assert_equal [dep('a')], @set.dependencies
+
+    assert_equal %w[git://github.com/example/example.git master],
+                 @git_set.repositories['a']
+
+    expected = { 'a' => '!' }
+
+    assert_equal expected, @gda.dependencies
+  end
+
   def test_gem_group
     @gda.gem 'a', :group => :test