-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'gem build' should warn on restrictive permissions #191
Comments
This should be an easy feature to add. Without a patch it will be closed though ☹ |
OK. That's fair. Here's a pull request. |
Closing this for now... if others desire executable checking they should reopen and add. |
This would help address a number of issues regarding gems and permissions. #191 rubygems/bundler#2136 |
The executable checking appears to be implemented by @0f2cacc2 (the tests for the feature, at least) |
Check $! after Dir.exists? returns false.
Obviously gem uses the permissions set locally and applies them to the packaged files. Obviously this is a gem issue, but gem developers are ignorant on this. See: rubygems/rubygems#272 rubygems/rubygems#707 rubygems/rubygems#191 and related issues.
Usually you'll always want to allow access to anyone in your group or even everyone on the system access to your gem. it would be a nice feature if 'gem build' warned when you built a gem with restrictive permissions. We've had a few instances where this wasn't caught and it causes issues when people try to start script/console and similar things.
The text was updated successfully, but these errors were encountered: