Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'gem build' should warn on restrictive permissions #191

Closed
aerickson opened this issue Sep 14, 2011 · 5 comments
Closed

'gem build' should warn on restrictive permissions #191

aerickson opened this issue Sep 14, 2011 · 5 comments

Comments

@aerickson
Copy link

Usually you'll always want to allow access to anyone in your group or even everyone on the system access to your gem. it would be a nice feature if 'gem build' warned when you built a gem with restrictive permissions. We've had a few instances where this wasn't caught and it causes issues when people try to start script/console and similar things.

@ghost ghost assigned zenspider Sep 22, 2011
@drbrain
Copy link
Member

drbrain commented Nov 28, 2012

This should be an easy feature to add. Without a patch it will be closed though ☹

@aerickson
Copy link
Author

OK. That's fair. Here's a pull request.

#400

@aerickson
Copy link
Author

Closing this for now... if others desire executable checking they should reopen and add.

@rbeede
Copy link

rbeede commented Dec 2, 2013

This would help address a number of issues regarding gems and permissions.

#191
http://projects.puppetlabs.com/issues/16871
#707

rubygems/bundler#2136
#560
rubygems/rubygems.org#568
#429
#272

@drbrain
Copy link
Member

drbrain commented Dec 2, 2013

The executable checking appears to be implemented by @0f2cacc2 (the tests for the feature, at least)

nobu pushed a commit to nobu/rubygems that referenced this issue Jan 12, 2014
Check $! after Dir.exists? returns false.
phw added a commit to phw/ruby-discid that referenced this issue Aug 27, 2015
Obviously gem uses the permissions set locally and applies them to the packaged files. Obviously this is a gem issue, but gem developers are ignorant on this. See:

rubygems/rubygems#272
rubygems/rubygems#707
rubygems/rubygems#191

and related issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants