Remove shared libraries before copying them into place #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue rubygems#1037 When building an extension that's still loaded into memory, cp_r replaces the file contents of the same inode. Since Linux mmaps shared libs, they will get reloaded but not relocated, leading to corruption of the GOT/PLT. The fix is to unlink the destination before copying, which creates a new inode and prevents the file from being reloaded.
|
👍 tried on liquid-c right ? |
|
@camilo yep, fixes the issue. |
|
Patch looks good to me! 👍 |
drbrain
added
status - accepted
type: bug report
category: other
category: install
and removed
category: other
labels
drbrain
added a commit
that referenced
this pull request
Nov 30, 2014
Remove shared libraries before copying them into place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1037
When building an extension that's still loaded into memory, cp_r replaces the file contents of the same inode. Since Linux mmaps shared libs, they will get reloaded but not relocated, leading to corruption of the GOT/PLT.
The fix is to unlink the destination before copying, which creates a new inode and prevents the file from being reloaded.
A test for this would be fairly complicated, but if necessary I can add one.
@dylanahsmith @camilo @csfrancis