Speed up rubygem's Kernel.require #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this reduces about 10% total time of Kernel.require on my test environment.
this reduces about 10% total time of Kernel.require on my test environment.
…ble. calling the original Kernel.require with a full path is about 25% faster than with path-less paramter. this reduces about 5% total time of rubygem's Kernel.require on my test environment.
drbrain
added a commit
that referenced
this pull request
Nov 30, 2014
Speed up rubygem's Kernel.require
drbrain
added a commit
that referenced
this pull request
Nov 30, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of some ideas for the speed.
Without changing the existing algorithm, it realized the speed mainly by taking advantage of the cache.
In case of executing
Kernel.requireabout 60 gems that in my test environment, approximately 25% of the speed has been achieved by these changes.