Fix some path quoting issues in the test suite #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests that has a pwd that includes brackets () these tests will fail.
Why: In the event that brackets () exist in the directory structure, running the rubygems test suite will fail. This fix resolves that issue by properly quoting the good_rake/bad_rake paths.
djberg96
added a commit
that referenced
this pull request
Aug 25, 2015
Fix some path quoting issues in the test suite
|
Looks good to me. |
djberg96
added a commit
that referenced
this pull request
Aug 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the test suite with a directory structure that includes brackets
()would cause multiple tests to fail. This PR resolves those issues.