Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error if find_by_name returns with nil #1494

Merged
merged 1 commit into from Feb 18, 2016

Conversation

h-z
Copy link
Contributor

@h-z h-z commented Feb 18, 2016

We encountered a dependency collision where meaningful error message got lost because of an unhandled nil-check.

@krainboltgreene
Copy link

👍

@duckinator
Copy link
Member

👍, merging.

duckinator added a commit that referenced this pull request Feb 18, 2016
raise error if find_by_name returns with nil
@duckinator duckinator merged commit 70ef850 into rubygems:master Feb 18, 2016
@segiddins
Copy link
Member

👍🏻

@h-z h-z deleted the fix-gem-activate branch February 18, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants