restore but deprecate support for Array values on Gem.paths=
#1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users (most notably Spring users with generated bin files) are passing Arrays as values in the hash to `Gem.paths=`. This commit restores support for Array values but issues a deprecation warning. The point is to warn people about their broken code, but allow RubyGems to continue to work, thus reducing "upgrade friction".
tenderlove
force-pushed
the
non_env_warn
branch
from
0c79d9f
to
a6b69e9
Compare
|
👍 |
|
@homu r+ |
|
📌 Commit a6b69e9 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Feb 27, 2016
restore but deprecate support for Array values on `Gem.paths=` Some users (most notably Spring users with generated bin files) are passing Arrays as values in the hash to `Gem.paths=`. This commit restores support for Array values but issues a deprecation warning. The point is to warn people about their broken code, but allow RubyGems to continue to work, thus reducing "upgrade friction". @drbrain I'm not sure about the deprecation cycle, so I just added a deprecation message. In what version should we drop support for this? /cc @jonleighton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users (most notably Spring users with generated bin files) are
passing Arrays as values in the hash to
Gem.paths=. This commitrestores support for Array values but issues a deprecation warning. The
point is to warn people about their broken code, but allow RubyGems to
continue to work, thus reducing "upgrade friction".
@drbrain I'm not sure about the deprecation cycle, so I just added a deprecation message. In what version should we drop support for this?
/cc @jonleighton