Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry with :prerelease when no suggestions are found #1696

Merged
merged 1 commit into from Aug 26, 2016

Conversation

sonalkr132
Copy link
Member

Description:

closes: #116
When no matches are found with latest specs, suggest_gems_from_name will retry with prerelease specs.

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends
  • Squash commits

I will abide by the code of conduct.

@segiddins
Copy link
Member

👍

@indirect
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Aug 26, 2016

📌 Commit fc2285a has been approved by indirect

@homu
Copy link
Contributor

homu commented Aug 26, 2016

⚡ Test exempted - status

@homu homu merged commit fc2285a into rubygems:master Aug 26, 2016
homu added a commit that referenced this pull request Aug 26, 2016
Retry with :prerelease when no suggestions are found

# Description:
closes: #116
When no matches are found with latest specs, `suggest_gems_from_name` will retry with prerelease specs.
# Tasks:

- [x] Describe the problem / feature
- [x] Write tests
- [x] Write code to solve the problem
- [ ] Get code review from coworkers / friends
- [ ] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@sonalkr132 sonalkr132 deleted the suggest_prerelase branch August 26, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install should suggest pre-release Gems
5 participants