New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Source] Autoload fileutils #1906
Conversation
Since fileutils is now a gem
Any objection to this? |
I wonder why we use autoload for default gem. PS. Matz is against to use |
The removal of autoload would make bundler and rubygems setup much much slower, and I think autoload is far preferable to manually adding |
@hsbt Generally true that it should be avoid because of threading issues from what I've read. But, rubygems isn't typically used as a library, so I'm not sure how much real risk there is. |
@djberg96 FYI autoload has officially been threadsafe since 2.0 (ruby/ruby@1e7f99d)... though I've seen hints of bugs, so whether that's informative may depend on how recent your existing information is. 😅 (Since that change, I'm not sure why it would still be removed, tbh.. but that's a discussion for elsewhere.) |
@matthewd Ok, thanks. Alright, then I say merge. |
@homu r+ |
📌 Commit 535d405 has been approved by |
…dins [Source] Autoload fileutils # Description: Since fileutils is now a gem # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
☀️ Test successful - status |
Description:
Since fileutils is now a gem
Tasks:
I will abide by the code of conduct.