Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis and Appveyor build status to README. #1918

Merged
merged 1 commit into from May 11, 2017

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented May 10, 2017

Description:

I added Travis and Appveyor build status to README.
Seeing those easily must be better to maintain rubygems.

I referred below gem packages for the README.
https://github.com/rspec/rspec-core/blob/master/README.md
https://github.com/sparklemotion/nokogiri/blob/master/README.md

You can check modified README here.
https://github.com/junaruga/rubygems/blob/feature/add-travis-badge/README.md


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@segiddins
Copy link
Member

👍

@hsbt
Copy link
Member

hsbt commented May 11, 2017

@homu r+

@homu
Copy link
Contributor

homu commented May 11, 2017

📌 Commit c3c2213 has been approved by hsbt

homu added a commit that referenced this pull request May 11, 2017
Add Travis and Appveyor build status to README.

# Description:

I added Travis and Appveyor build status to README.
Seeing those easily must be better to maintain `rubygems`.

I referred below gem packages for the README.
https://github.com/rspec/rspec-core/blob/master/README.md
https://github.com/sparklemotion/nokogiri/blob/master/README.md

You can check modified README here.
https://github.com/junaruga/rubygems/blob/feature/add-travis-badge/README.md

______________

# Tasks:

- [X] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@homu
Copy link
Contributor

homu commented May 11, 2017

⌛ Testing commit c3c2213 with merge 3f3337e...

@homu
Copy link
Contributor

homu commented May 11, 2017

☀️ Test successful - status

@homu homu merged commit c3c2213 into rubygems:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants