Code Improvement: Inheritance corrected #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that https://github.com/rubygems/rubygems/pull/1942/files#diff-2f4ccf4e08dba90f734c2f15cd2c47d8R9 |
|
Cool, thanks! @homu r+ |
|
📌 Commit f641120 has been approved by |
|
⌛ Testing commit f641120 with merge 6d63769... |
homu
added a commit
that referenced
this pull request
Jun 5, 2017
Code Improvement: Inheritance corrected # Description: Class inherited from `Gem::Commands::QueryCommand` here instead of `Gem::Command`. ## Reason: I have copied code from another command file but forgot to change this portion of code. Thanks for point this out @simi. ______________ # Tasks: - [x] Describe the problem / feature - [] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status |
|
💥 Test timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Class inherited from
Gem::Commands::QueryCommandhere instead ofGem::Command.Reason:
I have copied code from another command file but forgot to change this portion of code.
Thanks for point this out @simi.
Tasks:
I will abide by the code of conduct.