Small style fixes to Installer Set #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[-] Remove redundant comma from InstallerSet#local?
bronzdoc
reviewed
Aug 8, 2017
| @@ -193,7 +193,7 @@ def load_spec name, ver, platform, source # :nodoc: | |||
| # Has a local gem for +dep_name+ been added to this set? | |||
|
|
|||
| def local? dep_name # :nodoc: | |||
| spec, = @local[dep_name] | |||
| spec = @local[dep_name] | |||
There was a problem hiding this comment.
Hey, thanks for contributing to rubygems :)
I don't think that comma is just for style purposes, that comma there ensure we get the spec part from @local[dep_name]
since @local[dep_name] can be equal to [spec, source]
There was a problem hiding this comment.
Thank you for your comment. Maybe you can point on some places in the rubygems that can be useful for the newbie contributor like me to help this gem out?
There was a problem hiding this comment.
If that's the case, this might be more clear:
spec, _source = @local[dep_name]Or:
spec, _ = @local[dep_name][+] Add throwaway variable _ to make intention of getting only the spec clearer.
|
Thanks! @homu r+ |
|
@bundlerbot r+ |
|
📌 Commit e13e2b7 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Aug 8, 2017
Small style fixes to Installer Set [-] Remove redundant comma from InstallerSet#local?
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[-] Remove redundant comma from InstallerSet#local?