Add --[no-]check-development option to cleanup command #2061
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to check so it keeps backward compatibility.
godfat
added a commit
to godfat/gem-compact
that referenced
this pull request
Nov 4, 2017
segiddins
approved these changes
Nov 9, 2017
|
@bronzdoc @segiddins Are there any actions I need to take? Do we need more reviews? How do I move this forward? Thank you for looking into this! |
|
@bundlerbot r+ |
|
📌 Commit 47be81b has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Nov 13, 2017
Add --[no-]check-development option to cleanup command Default to check so it keeps backward compatibility. # Description: I just realized that there's no way to force cleaning up gems without checking development dependency. I wish at least we have an option: ``` gem cleanup --no-check-development ``` This is a bit too verbose to my taste, but to make it backward compatible and consistent with the uninstall command, this is probably the way to do it. Thanks for reviewing. ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Nov 13, 2017
Add --[no-]check-development option to cleanup command Default to check so it keeps backward compatibility. # Description: I just realized that there's no way to force cleaning up gems without checking development dependency. I wish at least we have an option: ``` gem cleanup --no-check-development ``` This is a bit too verbose to my taste, but to make it backward compatible and consistent with the uninstall command, this is probably the way to do it. Thanks for reviewing. ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status-travis |
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to check so it keeps backward compatibility.
Description:
I just realized that there's no way to force cleaning up gems without checking development dependency. I wish at least we have an option:
This is a bit too verbose to my taste, but to make it backward compatible and consistent with the uninstall command, this is probably the way to do it.
Thanks for reviewing.
Tasks:
I will abide by the code of conduct.