Merge glob pattern using braces #2072
Conversation
| @@ -442,15 +442,15 @@ def rb_files_in dir | |||
| # for installation of bundler as default gems | |||
| def template_files | |||
There was a problem hiding this comment.
Awesome! While we're at it, can you change this method to just call template_files_in "bundler/lib" so we're not duplicating the logic? Thanks!
There was a problem hiding this comment.
template_files_in "bundler/lib" is not working this method. Because installation phase needs to template files with prefix of bundler like bundler/templates/newgem/... . But uninstallation phase doesn't need it prefix.
There was a problem hiding this comment.
sorry, in that case template_files_in "bundler/lib/bundler" should be equivalent?
There was a problem hiding this comment.
It's good to equivalent template_files_in for template_files method.
|
I merge this. we need to simplify this installer logic. |
|
@bundlerbot r+ |
|
📌 Commit bb33027 has been approved by |
|
⌛ Testing commit bb33027 with merge c06efbc... |
Merge glob pattern using braces Remove duplicated directory path. - [X] Describe the problem / feature - [ ] Write tests - [X] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status-travis |
Remove duplicated directory path.
I will abide by the code of conduct.